Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kotlin 2.0 #2960

Closed
pvdmde opened this issue Jun 26, 2024 · 7 comments · Fixed by #2964
Closed

Support for Kotlin 2.0 #2960

pvdmde opened this issue Jun 26, 2024 · 7 comments · Fixed by #2964
Labels
Missing repro Platform: Android This issue is specific to Android

Comments

@pvdmde
Copy link

pvdmde commented Jun 26, 2024

Description

Looks like there's an issue when using Kotlin 2.0 in the app.

Steps to reproduce

Update kotlin version to 2.0

Snack or a link to a repository

nope

Gesture Handler version

not up to date, but code looks similar now

React Native version

0.73.0

Platforms

Android

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added Missing repro Platform: Android This issue is specific to Android labels Jun 26, 2024
@pvdmde
Copy link
Author

pvdmde commented Jun 26, 2024

Screenshot 2024-06-26 at 12 04 20

Current line:

private val handlersComparator = Comparator<GestureHandler<*>?> { a, b ->

@j-piasecki
Copy link
Member

Could you verify that #2964 solves the problem in your case?

@pvdmde
Copy link
Author

pvdmde commented Jun 27, 2024

Confirmed. Thanks! Hope to see a release with this one :)

j-piasecki added a commit that referenced this issue Jun 28, 2024
## Description

Should close
#2960

Changes the comparator type to work only with non-null objects, since
it's only used in this way. It was probably a leftover from migration to
Kotlin.

## Test plan

Build the app
@pvdmde
Copy link
Author

pvdmde commented Jul 18, 2024

I'd like to ask for a patch release with this one, as it fixes a blocker to update.

@pvdmde
Copy link
Author

pvdmde commented Jul 25, 2024

@j-piasecki can you trigger a release to unblock upgrading projects to kotlin 2.0?

@j-piasecki
Copy link
Member

We'll most likely release it early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro Platform: Android This issue is specific to Android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants