Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behavior of content overflow inside touchable #2619

Closed
JoshuaJADaniel opened this issue Oct 4, 2023 · 7 comments
Closed

Odd behavior of content overflow inside touchable #2619

JoshuaJADaniel opened this issue Oct 4, 2023 · 7 comments
Labels
Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided

Comments

@JoshuaJADaniel
Copy link

Description

When content within a touchable uses absolute positioning to move elements outside its boundaries, the overflowing content is hidden. In contrast, once the touchable is replaced with a view, the overflowing content becomes visible.

b23d86b0-3e81-495d-beaa-782fdad66fef

Steps to reproduce

  1. Open the Snack
  2. Select Android
  3. Run either locally or online

Snack or a link to a repository

https://snack.expo.dev/@joshuajadaniel/overflow-hidden-inside-button

Gesture Handler version

~2.12.0

React Native version

0.72.3

Platforms

Android

JavaScript runtime

Hermes

Workflow

Expo managed workflow

Architecture

Paper (Old Architecture)

Build type

Debug mode

Device

Real device

Device model

Samsung Galaxy S22

Acknowledgements

Yes

@github-actions github-actions bot added Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided labels Oct 4, 2023
@m-bert
Copy link
Contributor

m-bert commented Oct 5, 2023

Hi @JoshuaJADaniel! I've just looked at it.

It works on my Samsung S20+ and on Pixel 6 emulator. Also, the snack that you've provided works fine. Could you give some more information?

Edit: I've tested that on newest version of Gesture Handler. Could you please upgrade it to 2.13.1 and check if it works?

@JoshuaJADaniel
Copy link
Author

JoshuaJADaniel commented Oct 5, 2023

Hey @m-bert, just tested again today.

  • In development server running through Expo Go (or the Snack), the issue still appears.
  • In release build, it works as expected.

Any idea why this discrepancy may exist?

@j-piasecki
Copy link
Member

j-piasecki commented Oct 10, 2023

@JoshuaJADaniel I believe the Expo API 49 (and thus Expo Go) still uses Gesture Handler 2.12. If you do a release build it will use the versions from your package.json.

@JoshuaJADaniel
Copy link
Author

That could perhaps be the case, although sometimes bumping up or down a package version does impact the Expo Go behavior, which would imply that the package.json versions do matter to some extent at least. In any case, since the release build is working as expected, I am closing this issue.

@j-piasecki
Copy link
Member

That could perhaps be the case, although sometimes bumping up or down a package version does impact the Expo Go behavior, which would imply that the package.json versions do matter to some extent at least.

That's correct, Expo Go is compiled with specific versions of libraries, but the JS code is generated by the bundler. So if changes were in the JS code they would be reflected in Expo Go, if they were in the native code, they would not.

@j-piasecki
Copy link
Member

This issue was most likely fixed by this change.

@oleg1994
Copy link

oleg1994 commented Feb 15, 2024

@j-piasecki @m-bert
I'm experiencing same behavior.
"expo": "^50.0.6",
"react-native-gesture-handler": "~2.14.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

4 participants