-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bool_assert_comparison
#82
Comments
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHello @0xLucqs, I would like to participate in this issue. I am part of Dojo Coding and have been working with this language. I would be happy to contribute to this project. I am familiar with languages such as Java, C#, .NET, C++, JS, and TS. How I plan on tackling this issueI would replace the boolean comparisons in assert! macros with direct assertions, simplifying the code and making it more readable. Then, I would test the changes to ensure everything works as intended. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHi, I'm Mariángela, a software developer with a passion for innovative solutions. I'm excited about the opportunity to contribute to this project and collaborate with the team. How I plan on tackling this issueReplace assert_eq! and assert_ne! with assert! and its negated form as appropriate and review codebase to ensure that assertions are written in a more concise and idiomatic manner. |
@Josue19-08 the floor is yours. Don’t hesitate to ping me if you need any help |
Thanks @0xLucqs, excited to get started |
Hey @0xLucqs, I would like to take this issue up and contribute to cario lint from onlydust |
@Manush-2005 it's already assigned i'll try to find something else for you but i'm afraid you didn't really understand the goal of this project |
Hey @0xLucqs , sorry for raising an PR without understanding the core problem. I am closing the PR I rasied and finding another issue and will solve it using your help. |
What it does
This lint warns about boolean comparisons in assert-like macros.
Why is this bad?
It is shorter to use the equivalent.
Example
Use instead:
The text was updated successfully, but these errors were encountered: