Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pattern error opt in #417

Merged
merged 2 commits into from
Mar 10, 2024
Merged

make pattern error opt in #417

merged 2 commits into from
Mar 10, 2024

Conversation

softprops
Copy link
Owner

@softprops softprops commented Mar 10, 2024 •
edited
Loading

addresses #416

@softprops softprops marked this pull request as ready for review March 10, 2024 05:56
@softprops softprops merged commit 0e39c67 into master Mar 10, 2024
2 checks passed
@softprops softprops deleted the optin-pattern-errors branch March 10, 2024 05:56
klutchell
klutchell reviewed Mar 11, 2024
View reviewed changes
src/main.ts
throw new Error(`⚠️ Pattern '${pattern}' does not match any files.`);
} else {
console.warn(`🤔 Pattern '${pattern}' does not match any files.`);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When false (the default) and no files are matched, the action still fails on

action-gh-release/src/main.ts

Line 70 in 1ce812a

throw new Error(`⚠️ ${config.input_files} not include valid file.`);

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following up on this in #425

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should now be fixed in the latest v2 tag

softprops added a commit that referenced this pull request Mar 12, 2024
@softprops
followup to #417
f4bd966
@softprops softprops mentioned this pull request Mar 12, 2024
Merged
softprops added a commit that referenced this pull request Mar 12, 2024
@softprops
followup to #417 (#425)
6ffed59 
* followup to #417

* update changelog
@spicynugs spicynugs mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klutchell klutchell klutchell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@softprops @klutchell