Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disable yksom on CI" #152

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Revert "Disable yksom on CI" #152

merged 2 commits into from
Dec 2, 2024

Conversation

jacob-hughes
Copy link
Collaborator

This reverts commit a82587b.

@ltratt
Copy link
Member

ltratt commented Dec 2, 2024

A thought: to avoid future sync problems, .buildbot.sh should probably hardcode the commit of yksom it's testing. We can always keep this in sync (e.g. pointing it at a yet-to-be-merged commit-in-a-branch) and avoid the revert/unrevert dance.

@jacob-hughes
Copy link
Collaborator Author

jacob-hughes commented Dec 2, 2024 •
edited
Loading

Good idea. Something like this? 39587ee

@ltratt
Copy link
Member

ltratt commented Dec 2, 2024

Works for me! I think these commits are best left as-is.

@ltratt ltratt added this pull request to the merge queue Dec 2, 2024
Merged via the queue into softdevteam:master with commit 14aae8e Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ltratt ltratt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacob-hughes @ltratt