Use FSA to check for thread-locals #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Dec 2, 2024
compiler/rustc_middle/src/ty/util.rs
Outdated
| if let ty::Adt(adt_def, ..) = self.kind() { | ||
| return tcx.get_diagnostic_item(sym::LocalKey).map_or(false, |t| adt_def.did() == t); | ||
| } | ||
| return false; |
There was a problem hiding this comment.
I think you'll get a clippy warning telling you "just use false here? If so, please force push a fix.
There was a problem hiding this comment.
Ah yeah. I don't think is setup to warn for this kind of thing on rustc, but I'll force push a fix anyway. For some reason just returning true/false without a return keyword and semicolon looks wrong to me, but it's not a hill I'll die on!
Finalizers in Alloy are run on a separate thread, so if a user tries to access a thread-local from within a drop method used as a finalizer it is almost certainly incorrect. This commit disallows this and emit an error when it happens.
jacob-hughes
force-pushed
the
thread_local_checks
branch
from
fc9dc6e to
0bd7b51
Compare
|
Force-pushed an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalizers in Alloy are run on a separate thread, so if a user tries to access a thread-local from within a drop method used as a finalizer it is almost certainly incorrect. This commit disallows this and emit an error when it happens.