Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay in table of mentions loading top of PDF? #6

Open
jameshowison opened this issue Nov 16, 2021 · 2 comments
Open

Delay in table of mentions loading top of PDF? #6

jameshowison opened this issue Nov 16, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jameshowison
Copy link

The new PDF loading feature is great.

The table of mentions (with the page3, page4, page8 lists) arrives quite a bit after the PDF is displayed. Could we have a "loading mentions" message that is then replaced by the table? Perhaps "Loading mentions ... can take 10-15 seconds" with a spinner?

@kermitt2
Copy link
Collaborator

Thanks !

The loading time will be improved in the next days, I need to create an additional arangodb index for the annotations on the online demo server. It should then be faster. However for long documents, it's not the loading of annotations that takes time, but their display on the PDF. It depends then on your local machine, laptop, etc.

Related to this:

  • the display of PDF should be follow the download streaming, so start to render page after page as they are arriving (right now I display the PDF only when everything is arrived, but it was just a first iteration)
  • the additional of annotations could also be page by page, as pages are rendered, instead of waiting that the whole PDF is rendered.

And indeed a spinner and a better "waiting" message help and are cheap to add.

@kermitt2 kermitt2 added the enhancement New feature or request label Nov 16, 2021
@kermitt2 kermitt2 self-assigned this Nov 16, 2021
@kermitt2
Copy link
Collaborator

kermitt2 commented Dec 6, 2021

Waiting message has been added for "table of mentions" loading too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants