Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOFATracer Report to Zipkin enable true when Zipkin dependency is on classpath #28

Closed
guanchao-yang opened this issue Jul 9, 2018 · 0 comments
Closed

SOFATracer Report to Zipkin enable true when Zipkin dependency is on classpath #28

guanchao-yang opened this issue Jul 9, 2018 · 0 comments
Assignees
@guanchao-yang
Labels
enhancement New feature or request
Milestone
2.1.2

Comments

@guanchao-yang
Copy link
Member

Describe

Now,if we want to report data to Zipkin,we shoule add Zipkin dependency and configure Zipkin enabled.

# enable Zipkin
com.alipay.sofa.tracer.zipkin.enabled=true
# Zipkin server url ,such as http://zipkin-cloud.host.net:9411
com.alipay.sofa.tracer.zipkin.baseUrl=http://zipkin-cloud.host.net:9411

Expected

After we add Zipkin dependency,we only configure com.alipay.sofa.tracer.zipkin.baseUrl. It's not need configure com.alipay.sofa.tracer.zipkin.enabled=true

Actual

Now,we must configure com.alipay.sofa.tracer.zipkin.enabled=true
@guanchao-yang guanchao-yang added the enhancement New feature or request label Jul 9, 2018
@guanchao-yang guanchao-yang added this to the 2.1.2 milestone Jul 9, 2018
@guanchao-yang guanchao-yang self-assigned this Jul 9, 2018
@guanchao-yang guanchao-yang mentioned this issue Jul 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guanchao-yang guanchao-yang

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
1 participant
@guanchao-yang