Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI builds for new versions of dependencies from crates.io #158

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

soenkehahn
Copy link
Owner

@soenkehahn soenkehahn commented Aug 13, 2021

There's a weird problem caused be the newly released bitflags-1.3.1 on CI on older rustcs. This causes cargo build --bin test_executables_helper --features test_executables to fail. Unfortunately we only execute that command from within the test-suite. And if it fails, the test-suite hangs. :( This PR makes the test-suite crash when this happens.

Edit: point to bitflags instead of libc.

@soenkehahn
Copy link
Owner Author

Here's an issue about the root cause: nix-rust/nix#1491.

This PR now also pins bitflags to version 1.2.1 to work around this issue. Since bitflags is only a dev-dependency, I think that should be fine.

@soenkehahn soenkehahn changed the title Exit test-suite process when compiling of test-helpers fails Fix builds for new versions of dependencies from crates.io Aug 13, 2021
@soenkehahn soenkehahn changed the title Fix builds for new versions of dependencies from crates.io Fix CI builds for new versions of dependencies from crates.io Aug 13, 2021
@soenkehahn soenkehahn enabled auto-merge (squash) August 13, 2021 06:09
@soenkehahn soenkehahn merged commit b40295b into master Aug 13, 2021
@soenkehahn soenkehahn deleted the error-exit branch August 13, 2021 06:13
This was referenced Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant