Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K5_2 signature change #3

Closed
kiwifb opened this issue Aug 6, 2024 · 2 comments
Closed

K5_2 signature change #3

kiwifb opened this issue Aug 6, 2024 · 2 comments

Comments

@kiwifb
Copy link

kiwifb commented Aug 6, 2024

I'll ask here before going to open an issue with sagemath. After the update to 2024.5.1 in sagemath it seems the tested signature has changed

File "/usr/lib/python3.12/site-packages/sage/knots/knotinfo.py", line 898, in sage.knots.knotinfo.KnotInfoBase.signature
Failed example:
    KnotInfo.K5_2.signature()       # optional - database_knotinfo
Expected:
    1
Got:
    -2

Trying with 2024.8.1 gives the same result (-2). I find it strange that the property of a particular knot would change like that. Was the doctest always wrong, or was there something wrong in the database or is something fishy going on?

@soehms
Copy link
Owner

soehms commented Aug 6, 2024

Was the doctest always wrong, or was there something wrong in the database or is something fishy going on?

No! The doctest didn' work before sagemath/sage#38118 which has been merged currently. In that PR the doctest has been made working but with a wrong result. This will be fixed with sagemath/sage#38254.

@kiwifb
Copy link
Author

kiwifb commented Aug 6, 2024

Was always wrong. I feel better about that now. Good to see there is work to fix it.

@kiwifb kiwifb closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants