Add https.Server to accepted types #4351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [x] a bug fix * [ ] a new feature * [ ] an update to the documentation * [ ] a code change that improves performance * [ ] other ### Current behavior Currently you can't attach a https server to the socket.io instance. You would first need to cast it to any and then to http.Server if you want to use it ### New behavior Socket.io should now also accept https.Server ### Other information (e.g. related issues)
darrachequesne
pushed a commit
that referenced
this pull request
May 3, 2022
|
Merged as 9b43c91. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
Currently you can't attach a https server to the socket.io instance. You would first need to cast it to any and then to http.Server if you want to use it
New behavior
Socket.io should now also accept https.Server
Other information (e.g. related issues)