Rounding

[kinto-b]

Currently pretty much every shadow will include a call to signif, e.g.

... %>%
  prj_shadow_if(is_col(.), "{100*signif(p, 2)}% ({round(n)})") %>%
...

We should do rounding to 2 significant figures by default

[gorcha]

I'd recommend setting default rounding as a package option

[kinto-b]

100%

Only question would be how to allow the user to override that behaviour on an ad hoc one-off basis

[gorcha]

Hmmm, good call

[kinto-b]

I reckon a global option, prj_digits=2, plus a digits argument to prj_project (and associated functions), is the best way to go.

Then we add a transformer to glue_each_in()

can_numeric <- function (x) {
    !any(!is.na(x) & is.na(suppressWarnings(as.numeric(x))))
}

round_transformer <- function(digits = getOption("prj_digits")) {
    function(text, envir) {
        if (can_numeric(text)) text <- round(as.numeric(text), digits)
        glue::identity_transformer(text, envir)
    }
}

And we have in prj_cast_shadow()

if (!is.null(digits)) {
  oldopts <- options(list(prj_digits = digits)
  on.exit(options(oldopts))
}