Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add more configuration parameters #234

Merged
merged 6 commits into from
Dec 21, 2018
Merged

Conversation

vinayak-mehta
Copy link
Contributor

@vinayak-mehta vinayak-mehta commented Dec 20, 2018

Fixes #229, #230 and #233.

  • strip_text: To define characters that should be stripped from each string.
    • code
    • test
    • doc
  • edge_tol: Tolerance parameter for extending textedges vertically.
    • code
    • test
    • doc
  • resolution: To define resolution ghostscript will use to convert PDF to PNG.
    • code

@codecov-io
Copy link

codecov-io commented Dec 20, 2018

Codecov Report

Merging #234 into master will decrease coverage by 0.43%.
The diff coverage is 91.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #234      +/-   ##
=========================================
- Coverage   87.93%   87.5%   -0.44%     
=========================================
  Files          13      13              
  Lines        1409    1416       +7     
  Branches      333     333              
=========================================
  Hits         1239    1239              
- Misses        114     121       +7     
  Partials       56      56
Impacted Files Coverage Δ
camelot/io.py 100% <ø> (ø) ⬆️
camelot/parsers/lattice.py 89.17% <100%> (+0.11%) ⬆️
camelot/core.py 91.35% <100%> (-2.31%) ⬇️
camelot/cli.py 85.58% <100%> (+0.4%) ⬆️
camelot/parsers/stream.py 91.66% <80%> (+0.61%) ⬆️
camelot/utils.py 81.25% <91.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89e147...be1f0a2. Read the comment docs.

@vinayak-mehta vinayak-mehta changed the title Add more configuration parameters [WIP] Add more configuration parameters Dec 20, 2018
@vinayak-mehta vinayak-mehta changed the title [WIP] Add more configuration parameters [MRG] Add more configuration parameters Dec 21, 2018
@vinayak-mehta vinayak-mehta merged commit 175ba32 into master Dec 21, 2018
@vinayak-mehta vinayak-mehta deleted the add-060-kwargs branch December 21, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants