Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Use find_executable for gs and raise error if not found #166

Merged
merged 5 commits into from
Oct 23, 2018
Merged

[MRG] Use find_executable for gs and raise error if not found #166

merged 5 commits into from
Oct 23, 2018

Conversation

vinayak-mehta
Copy link
Contributor

Fixes #140. Based on suggestion by @topper-123 here.

@vinayak-mehta vinayak-mehta changed the title Use find_executable for gs and raise error if not found [MRG] Use find_executable for gs and raise error if not found Oct 22, 2018
@codecov-io
Copy link

codecov-io commented Oct 22, 2018 •
edited
Loading

Codecov Report

Merging #166 into master will decrease coverage by 0.22%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage    84.4%   84.17%   -0.23%     
==========================================
  Files          13       13              
  Lines        1212     1226      +14     
  Branches      290      294       +4     
==========================================
+ Hits         1023     1032       +9     
- Misses        146      150       +4     
- Partials       43       44       +1
Impacted Files Coverage Δ
camelot/parsers/lattice.py 89.47% <58.33%> (-2.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f734af3...a701faf. Read the comment docs.

@vinayak-mehta vinayak-mehta changed the title [MRG] Use find_executable for gs and raise error if not found [WIP] Use find_executable for gs and raise error if not found Oct 23, 2018
@vinayak-mehta vinayak-mehta changed the title [WIP] Use find_executable for gs and raise error if not found [MRG] Use find_executable for gs and raise error if not found Oct 23, 2018
@vinayak-mehta vinayak-mehta merged commit a78ef7f into master Oct 23, 2018
@vinayak-mehta vinayak-mehta deleted the fix_gs_exe branch October 23, 2018 15:42
kirbs- pushed a commit to kirbs-/camelot that referenced this pull request Jul 31, 2020
@vinayak-mehta
Merge pull request atlanhq#166 from stevestock/patch-1
4b08165 
Update install.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinayak-mehta @codecov-io