Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 1] Added .editorconfig #151

Merged
merged 1 commit into from
Oct 19, 2018
Merged

[MRG + 1] Added .editorconfig #151

merged 1 commit into from
Oct 19, 2018

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files          12       12           
  Lines        1198     1198           
  Branches      288      288           
=======================================
  Hits         1012     1012           
  Misses        142      142           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5645ef5...c5f9daa. Read the comment docs.

@vinayak-mehta
Copy link
Contributor

@KOLANICH Is this a config for the GitHub file editor?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Oct 18, 2018

It is an editor-neutral config (see https://editorconfig.org for the list of editors supporting it); GH supports it too. I use it with a Notepad++ plugin, without that it is problematic to use NPP (and any other editor without the feature to auto-deduce the settings from actual documents contents) with the projects using spaces because I use tabs and for me NPP is set up to use tabs.

Please note that it would be good to add it into your repo boilerplate (of course after customization, the one in this PR matches PEP8 used in this repo, but pep8 is not mandatory, with editorconfig you can use tabs without fear of shifts in text since size of a tab is configured).

@vinayak-mehta vinayak-mehta changed the title Added .editorconfig [MRG + 1] Added .editorconfig Oct 19, 2018
@vinayak-mehta vinayak-mehta merged commit 7baea06 into atlanhq:master Oct 19, 2018
@vinayak-mehta
Copy link
Contributor

@KOLANICH Thanks for the contribution! (And making me aware of https://editorconfig.org/ 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants