-
Notifications
You must be signed in to change notification settings - Fork 359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 73.19% 73.84% +0.64%
==========================================
Files 12 12
Lines 1231 1231
Branches 292 292
==========================================
+ Hits 901 909 +8
+ Misses 283 279 -4
+ Partials 47 43 -4
Continue to review full report at Codecov.
|
@vaibhavmule Is this a WIP or ready for merge? Can you name the title accordingly, I'll add my review after it is ready. EDIT: You should check out the PR contribution guidelines. |
@vinayak-mehta it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In the future, we might want to break these into separate tests.
@vaibhavmule Thanks for the contribution! |
@vinayak-mehta Also, I tried using |
BTW, what is |
I've taken the MRG philosophy from scikit-learn's contributing guidelines, which states that at least 2 +1s on the MRG label are needed (from core devs) to merge a PR. Since I'm the only one here right now, only a +1 suffices. This isn't in the docs right now, want to add it? |
Strange, what were the exact arguments that you used? It's working for me. |
referencing: #110