Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 1] Test UsageError for CLI #122

Merged
merged 3 commits into from
Oct 4, 2018

Conversation

vaibhavmule
Copy link
Contributor

@vaibhavmule vaibhavmule commented Oct 4, 2018

referencing: #110

@vaibhavmule vaibhavmule changed the title test usage erro for CLI test UsageError for CLI Oct 4, 2018
@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #122 into master will increase coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   73.19%   73.84%   +0.64%     
==========================================
  Files          12       12              
  Lines        1231     1231              
  Branches      292      292              
==========================================
+ Hits          901      909       +8     
+ Misses        283      279       -4     
+ Partials       47       43       -4
Impacted Files Coverage Δ
camelot/cli.py 93.47% <0%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d00937...1721cbb. Read the comment docs.

@vinayak-mehta
Copy link
Contributor

vinayak-mehta commented Oct 4, 2018

@vaibhavmule Is this a WIP or ready for merge? Can you name the title accordingly, I'll add my review after it is ready.

EDIT: You should check out the PR contribution guidelines.

@vaibhavmule vaibhavmule changed the title test UsageError for CLI [MRG] test UsageError for CLI Oct 4, 2018
@vaibhavmule vaibhavmule changed the title [MRG] test UsageError for CLI [WIP] test UsageError for CLI Oct 4, 2018
@vaibhavmule vaibhavmule changed the title [WIP] test UsageError for CLI [MRG] test UsageError for CLI Oct 4, 2018
@vaibhavmule
Copy link
Contributor Author

@vinayak-mehta it is ready for review.

Copy link
Contributor

@vinayak-mehta vinayak-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future, we might want to break these into separate tests.

@vinayak-mehta vinayak-mehta changed the title [MRG] test UsageError for CLI [MRG + 1] Test UsageError for CLI Oct 4, 2018
@vinayak-mehta vinayak-mehta merged commit 58eddd0 into atlanhq:master Oct 4, 2018
@vinayak-mehta
Copy link
Contributor

@vaibhavmule Thanks for the contribution!

@vaibhavmule vaibhavmule deleted the test-cli branch October 4, 2018 16:38
@vaibhavmule
Copy link
Contributor Author

@vinayak-mehta
Welcome, Yes, deff tests need to be broken down.

Also, I tried using --plot_type but it was giving error Error: no such option: --plot_type

@vaibhavmule
Copy link
Contributor Author

BTW, what is +1 in title?

@vinayak-mehta
Copy link
Contributor

I've taken the MRG philosophy from scikit-learn's contributing guidelines, which states that at least 2 +1s on the MRG label are needed (from core devs) to merge a PR. Since I'm the only one here right now, only a +1 suffices. This isn't in the docs right now, want to add it?

@vinayak-mehta
Copy link
Contributor

Also, I tried using --plot_type but it was giving error Error: no such option: --plot_type

Strange, what were the exact arguments that you used? It's working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants