Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG + 1] Update contributor's guide with new labels #116

Merged
merged 2 commits into from
Oct 2, 2018
Merged

[MRG + 1] Update contributor's guide with new labels #116

merged 2 commits into from
Oct 2, 2018

Conversation

johnnymetz
Copy link
Contributor

New labels are help wanted and good first issue

@johnnymetz johnnymetz mentioned this pull request Oct 2, 2018
Closed
@vinayak-mehta
Copy link
Contributor

LGTM.

@vinayak-mehta vinayak-mehta changed the title Update contributor's guide with new labels [MRG + 1] Update contributor's guide with new labels Oct 2, 2018
@vinayak-mehta vinayak-mehta self-requested a review October 2, 2018 18:45
vinayak-mehta
vinayak-mehta suggested changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@vinayak-mehta vinayak-mehta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnnymetz Can you also update the CONTRIBUTING.md?

@vinayak-mehta vinayak-mehta changed the title [MRG + 1] Update contributor's guide with new labels [WIP] Update contributor's guide with new labels Oct 2, 2018
@johnnymetz
Copy link
Contributor Author

@vinayak-mehta CONTRIBUTING.md is the one file I updated. Is there something else?

@johnnymetz
Copy link
Contributor Author

I need to update the labels in the docs. Should be done in a minute.

@codecov-io
Copy link

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   65.31%   65.31%           
=======================================
  Files          12       12           
  Lines        1231     1231           
  Branches      292      292           
=======================================
  Hits          804      804           
  Misses        389      389           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea79cf2...f8eacc6. Read the comment docs.

@vinayak-mehta
Copy link
Contributor

@vinayak-mehta CONTRIBUTING.md is the one file I updated. Is there something else?

Oops, I was referring to the one in the docs. I see that you've updated it. LGTM, merging.

@vinayak-mehta vinayak-mehta changed the title [WIP] Update contributor's guide with new labels [MRG + 1] Update contributor's guide with new labels Oct 2, 2018
@vinayak-mehta vinayak-mehta merged commit 2b8ae5f into atlanhq:master Oct 2, 2018
@vinayak-mehta
Copy link
Contributor

@johnnymetz Thanks for the contribution!

@johnnymetz johnnymetz deleted the update-contrib-guide-with-new-labels branch October 2, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayak-mehta vinayak-mehta vinayak-mehta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnnymetz @vinayak-mehta @codecov-io