Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the kwarg table_area to table_areas #165

Closed
vinayak-mehta opened this issue Oct 22, 2018 · 3 comments
Closed

Rename the kwarg table_area to table_areas #165

vinayak-mehta opened this issue Oct 22, 2018 · 3 comments
Labels
easy good first issue help wanted

Comments

@vinayak-mehta
Copy link
Contributor

The latter sounds more apt since it is a list and there can be multiple table areas on a page.
@vinayak-mehta
Copy link
Contributor Author

@dggs123 You can pick this up if you want.

@oliveiraigordev
Copy link

Can I look?

@pqrth pqrth mentioned this issue Oct 23, 2018
Merged
@vinayak-mehta
Copy link
Contributor Author

@IgorOliveira42 Sorry for the late reply, @pqrth already submitted a PR. You can check out other issues tagged with "help wanted".

vinayak-mehta pushed a commit that referenced this issue Oct 24, 2018
@pqrth @vinayak-mehta
Renames the keyword table_area to table_areas (#171)
32df09a 
`table_areas` sounds more apt since it is a list and there can be
multiple table areas on a page.

Closes #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinayak-mehta @oliveiraigordev