Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure code follows pep8 #123

Closed
vaibhavmule opened this issue Oct 4, 2018 · 6 comments
Closed

Make sure code follows pep8 #123

vaibhavmule opened this issue Oct 4, 2018 · 6 comments

Comments

@vaibhavmule
Copy link
Contributor

vaibhavmule commented Oct 4, 2018

Things need to fix to follow pep8.

  • E501 line too long
  • E127 continuation line over-indented for visual indent
  • W292 no newline at end of file
  • etc.
@vinayak-mehta
Copy link
Contributor

Thanks for filing! I was planning to do this for 0.2.1. In addition to PEP8, KR's code style makes a lot of sense to me. If you want to take this up, you can open a PR!

@Oshawk
Copy link
Contributor

Oshawk commented Oct 4, 2018

I will have a go at fixing this.

@vinayak-mehta
Copy link
Contributor

@Oshawk You can use flake8 to find places where changes are needed. But don't change everything that flake8 recommends, check out the KR code style in my comment above for guidelines.

@Oshawk
Copy link
Contributor

Oshawk commented Oct 4, 2018

Have done what I can #125

Happy to redo anything.

@vinayak-mehta
Copy link
Contributor

Hey @Oshawk, added my review on the PR.

@vinayak-mehta
Copy link
Contributor

@Oshawk Protip for your next PR: if you add a "Fixes #n" in your PR's description, GitHub will automatically close the associated issue #n when the PR is merged. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants