Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default look #53

Open
mirlip opened this issue Apr 10, 2019 · 3 comments
Open

default look #53

mirlip opened this issue Apr 10, 2019 · 3 comments

Comments

@mirlip
Copy link

mirlip commented Apr 10, 2019

When using this version of Filmic with Blender 2.8, it defaults to none for the look in viewport, making it very flat. Changing look in color management panel doesn't influence viewport, only render. What should I modify (in Blender or config.ocio) to make the default look to be base contrast for example? It seems to be very helpful for final render to use log, but if it breaks viewport, it's hard to work with.

@sobotka
Copy link
Owner

sobotka commented Apr 11, 2019

The base log encoding is designed that way for interchange. The default Blender configuration screwed it up, and includes the Base Contrast. It should not.

The rest of the other issues is because Blender’s colour pipeline is a cluster. If more folks cared, it might get fixed. To be clear, Blender’s viewport is broken if it doesn’t support looks.

@mirlip
Copy link
Author

mirlip commented Apr 11, 2019

thanks for the quick answer. So if I understand it right, there is no way to modify the config.ocio from your version to define a default look? Your work is really awesome, it would be sad to have it limited forever because of a quick and dirty implementation. From what I understand in the Blender's log, it defaults to "none" because it doesn't find the look it looks for. So if 'none' on filmic side could be "base contrast", then it would work for the viewport while still allowing to choose log encoding for the final render. I know it's a bit hacky, but it's still better than current situation.

@sobotka
Copy link
Owner

sobotka commented Apr 11, 2019

You could modify it by adding a stanza and a look.

The question is why? Why is the viewport busted?

Better to have more knowledgeable people focus on getting the software fixed, not having hacky workarounds. Until more people step up and keep the focus on a proper pixel pipeline, those things will remain broken forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants