Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to toggle service account usage #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjchand
Copy link

@cjchand cjchand commented Jul 21, 2022

Resolves #14

Adds new value: serviceAccount.enabled.

Verified behavior is unchanged if:

  1. serviceAccount.enabled = true
  2. serviceAccount.enabled is unspecified or commented out

Only if serviceAccount.enabled is explicitly set to false does it remove spec.template.spec.serviceAccountName

While I manually verified across the charts locally, here are some rudimentary proof points setting:

  1. Nothing - using default values
  2. Setting serviceAccount.enabled to false
  3. Setting Setting serviceAccount.enabled to true
 ✘ me@laptop  ~/Projects/personal/snyk-broker-helm   feature/service-account-enabled-toggle ● 
helm template snyk-broker charts/snyk-broker/. \ 
--set scmType=github.com \ 
--set brokerToken=my-broker-token \ 
--set scmToken=my-scm-token  \ 
--set brokerClientUrl=https://snyk-broker.example.com/broker | grep serviceAccountName
      serviceAccountName: snyk-broker
 me@laptop  ~/Projects/personal/snyk-broker-helm   feature/service-account-enabled-toggle ●  helm template snyk-broker charts/snyk-broker/. \ 
--set scmType=github.com \ 
--set brokerToken=my-broker-token \ 
--set scmToken=my-scm-token  \ 
--set brokerClientUrl=https://snyk-broker.example.com/broker \ 
--set serviceAccount.enabled=false | grep serviceAccountName
 ✘ me@laptop  ~/Projects/personal/snyk-broker-helm   feature/service-account-enabled-toggle ●  helm template snyk-broker charts/snyk-broker/. \ 
--set scmType=github.com \ 
--set brokerToken=my-broker-token \ 
--set scmToken=my-scm-token  \ 
--set brokerClientUrl=https://snyk-broker.example.com/broker \ 
--set serviceAccount.enabled=true \ 
--set serviceAccount.create=true | grep serviceAccountName
      serviceAccountName: snyk-broker

@cjchand cjchand requested a review from a team as a code owner July 21, 2022 21:01
@CLAassistant
Copy link

CLAassistant commented Sep 20, 2022

CLA assistant check
All committers have signed the CLA.

@jsutherland-snyk jsutherland-snyk requested review from a team and removed request for a team January 27, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment templates presume existence of service account
2 participants