-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [OSM-887] Bumping snyk-nuget-plugin
for various bugfixes
#4961
Conversation
360cb67
to
ed3ff5f
Compare
test/jest/acceptance/snyk-test/basic-test-all-languages.spec.ts
Outdated
Show resolved
Hide resolved
bde6902
to
97016ea
Compare
97016ea
to
1219b60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but I consistently am getting timeouts that is causing the pipeline to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are seeing this in the smoke tests, too. Will have a look today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotkas can you please disable that test for now? Somehow snyk test smoke
is hanging, and even debugging doesn't give me the foggiest, why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your risk assessment of this?
@bastiandoetsch it's all in beta and behind the beta argument, so I deem it low. |
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
This PR bumps the version of
snyk-nuget-plugin
in order to solve 3 bugs related to the .NET CLI beta that's under active development, namely, it fixes:targetAlias
where present instead of raw target name snyk-nuget-plugin#197.props
snyk-nuget-plugin#198 andWhich all caused
snyk test --dotnet-runtime-resolution
to fail.Where should the reviewer start?
For detailed investigation, see the three aforementioned PRs.
How should this be manually tested?
The
nuget-app-8-windows
fixture encompasses a.csproj
that contains all the features that previously broke.Any background context you want to provide?
N/A
What are the relevant tickets?
https://snyksec.atlassian.net/browse/OSM-887