Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🙏]Add option to exclude deactivated projects #11

Open
snykerjames opened this issue Mar 2, 2022 · 4 comments
Open

[🙏]Add option to exclude deactivated projects #11

snykerjames opened this issue Mar 2, 2022 · 4 comments

Comments

@snykerjames
Copy link

Would like to be able to exclude dependencies in deactivated projects from the export.

@scott-es
Copy link
Contributor

scott-es commented Jul 1, 2022

id like to make this default behavior. do you think we need a flag to --include-deactivated-projects?

@snykerjames
Copy link
Author

Makes sense.

My inclination would be to not add the flag immediately unless we get customer feedback that it's needed. However, there are a couple of related inputs I think we should also consider:

  • The customer scenario that led to this request did include the idea of optionally including deactivated projects, which suggests there is already a potential need for it.
  • Providing the option would enable a backward-compatible output (since deactivated projects are returned today) and could potentially reduce migration impact in cases where existing automations are dependent on this output.

@scott-es
Copy link
Contributor

scott-es commented Jul 5, 2022

if the default is that the deativated projects are included today, then the option would be to exclude deactivated projects, right?

@snykerjames
Copy link
Author

Yes, that's correct if we do not change the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants