Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Make the test rule depend on ghc-compact, to make this library's tests pass #677

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

alpmestan
Copy link
Collaborator

This commit also removes some leftover from my previous PR, sorry about that.

Copy link
Owner

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@snowleopard
Copy link
Owner

Will merge when CI finishes.

@alpmestan
Copy link
Collaborator Author

Oh, I didn't state it explicitly, so here it is: this fixes all the failing ghc-compact tests (quite likely all of them, since they presumably all need the library).

@snowleopard snowleopard merged commit f8d3f9b into master Sep 6, 2018
@snowleopard snowleopard deleted the alp/ghc-compact-tests branch September 6, 2018 13:31
@snowleopard
Copy link
Owner

CI still timeouts, so merging as is.

@alpmestan Thanks, I've attached the description to the commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants