Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-520524: Use NoOpTelemetryClient when CLIENT_IN_BAND_TELEMETRY_ENABLED is set to false #662

Closed
Nandakumar-M opened this issue Dec 17, 2021 · 2 comments
Closed

SNOW-520524: Use NoOpTelemetryClient when CLIENT_IN_BAND_TELEMETRY_ENABLED is set to false #662

Nandakumar-M opened this issue Dec 17, 2021 · 2 comments
Assignees
@sfc-gh-mknister
Labels
enhancement The issue is a request for improvement or a new feature

Comments

@Nandakumar-M
Copy link

Nandakumar-M commented Dec 17, 2021 •
edited
Loading

Currently, even when CLIENT_TELEMETRY_ENABLED is set to false, a TelemetryClient instance is created.

The method s addLogToBatch, sendBatch are implemented to do nothing when this parameter is set to false.

However, the singleton TelemetryThreadPool instance gets created through TelemetryThreadPool.getInstance() even when telemetry is disabled.

Instead, an instance of NoOpTelemetryClient could be used when telemetry is disabled.
@github-actions github-actions bot changed the title Use NoOpTelemetryClient when CLIENT_IN_BAND_TELEMETRY_ENABLED is set to false SNOW-520524: Use NoOpTelemetryClient when CLIENT_IN_BAND_TELEMETRY_ENABLED is set to false Dec 17, 2021
@sfc-gh-hchaturvedi sfc-gh-hchaturvedi added the enhancement The issue is a request for improvement or a new feature label Jan 20, 2022
@sfc-gh-dszmolka
Copy link
Contributor

I think this has been fixed with 6a8b926 somewhere along the road. Closing this issue.

@bpackter
Copy link

It is being overridden after calling any api (query/login)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-mknister sfc-gh-mknister

Labels
enhancement The issue is a request for improvement or a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Nandakumar-M @sfc-gh-hchaturvedi @sfc-gh-mknister @sfc-gh-dszmolka @bpackter