SNOW-1747516: Native libraries are not relocated

[laurentgo]

Please answer these questions before submitting your issue.
In order to accurately debug the issue this information is required. Thanks!

1. What version of JDBC driver are you using?

3.19.0

2. What operating system and processor architecture are you using?

OS X 14.6.1 (arm64)

3. What version of Java are you using?

Java 11

4. What did you do?

When using snowflake driver in an application, we experienced crashes we were able to attribute to use of conscrypt native library.
After inspection we realized that snowflake driver packages a relocated version of conscrypt (and grpc) but none of the native libraries bundled with those two artifacts are relocated themselves, and because of it there's a chance that snowflake driver may load a different version of the native library than the one bundled with snowflake

Netty (and by extension grpc-netty-shaded) has a builtin mechanism to detect relocation, and as long as the native libraries use the same relocation pattern (with dots (.) replaced with underscores (_)), netty classes do not need to be rewritten.

Conscrypt on the other hand does not seem to have a builtin mechanism, and along with the native libraries being renamed, the NativeCryptoJni class should be rewritten to change the prefix to search for.

5. What did you expect to see?

Application crashed (was expecting no crash)

6. Can you set logging to DEBUG and collect the logs?

No

[sfc-gh-dprzybysz]

Hi @laurentgo,
I have some questions to the issue

1. Does your application crashes when you are using it via the JDBC API standard interfaces?
2. Are you using explicitly any class from net.snowflake.client.jdbc.internal.** in your application? Those classes we consider internal and should not be used explicitly.
3. Have you tried snowflake-jdbc-thin? It does not shade google-cloud-storage (any many others) dependencies and then relocation issues should not happen.
4. For CLAAssistant check in PR to be fixed I think you should post first the comment that you read and signed CLA, recheck should be the second comment
5. Please rebase your PR if you still want it to be reviewed, tested and merged

[laurentgo]

Hi @laurentgo, I have some questions to the issue

1. Does your application crashes when you are using it via the JDBC API standard interfaces?

Yes, we do use it via the JDBC API

2. Are you using explicitly any class from `net.snowflake.client.jdbc.internal.**` in your application? Those classes we consider internal and should not be used explicitly.

No, we are not using using directly any snowflake internal classes

3. Have you tried snowflake-jdbc-thin? It does not shade google-cloud-storage (any many others) dependencies and then relocation issues should not happen.

I haven't but independently of me using it, I still do think the relocation issue on the main driver should be fixed

4. For CLAAssistant check in PR to be fixed I think you should post first the comment that you read and signed CLA, recheck should be the second comment

👍

5. Please rebase your PR if you still want it to be reviewed, tested and merged

I will

[sfc-gh-dprzybysz]

Hi @laurentgo
the tests of your PR are running now and we will review then
Please share more details about your setup (you don't have to do this here in OSS ticket, but you can send it to our Support Team e.g. as described in https://community.snowflake.com/s/article/How-To-Submit-a-Support-Case-in-Snowflake-Lodge )

[sfc-gh-dprzybysz]

Hi @laurentgo
your PR is merged, thank you for the contribution

[sfc-gh-dszmolka]

released with Snowflake JDBC driver v3.21.0