callHeartBeatWithQueryTimeout with default queryTimeout means 0 wait for future

[KarlHakanNordgren]

Hi hi

I'm puzzled by the following: The default value for queryTimeout is 0 which means that "that the driver should wait indefinitely" (see here). Looking at the callHeartBeatWithQueryTimeout I see that it tries to resolve a future with future.get(timeout, TimeUnit.SECONDS). According to the documentation for Future a 0 timeout here means a wait of "at most the given time" which is 0. (See here.)

What have I misunderstood?

[sfc-gh-spanaite]

@KarlHakanNordgren I think you probably missed where callHeartBeatWithQueryTimeout is called from:

public void callHeartBeat(int timeout) throws Exception, SFException {
    if (timeout > 0) {
      callHeartBeatWithQueryTimeout(timeout);
    } else {
      heartbeat();
    }
  }

This means we will call it only if queryTimeout > 0 otherwise we will call heartbeat() function which has a different logic.

[sfc-gh-spanaite]

@KarlHakanNordgren Any other questions or we're good with closing this issue?

[sfc-gh-spanaite]

Closing as this is not a bug. Feel free to open a new one if you still have questions.