Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-container-image-jib should support jib.dockerClient.executable config #454

Closed
snowdrop-bot opened this issue Nov 24, 2021 · 0 comments
Assignees
Labels
7 - Community development upstream/closed The issue has been closed in the upstream repository

Comments

@snowdrop-bot
Copy link
Collaborator

Jib allows configuration of the dockerClient that is invoked for loading the built image to local registry. This allows developers to explicitly build to docker, podman, buildah, etc. depending on what is available on their system as well as explicitly selecting one of them if multiple are present. This is analogous to the quarkus.docker.executable-name config property that is already supported, so I think it would make sense that the jib builder supports it as well.

There is also the dockerClient.executable config property that Jib supports which I think might be relevant here. If it is not then I think that a separate issue could be opened to add support for this to the quarkus-container-image-jib build plugin as quarkus.jib.dockerClient.executable=/usr/bin/podman. I use this in Cryostat to default the image builder to podman, but allow it to be overridden if some developer needs that to be docker (or probably buildah too - haven't tried that yet).

Originally posted by @andrewazores in quarkusio#16326 (comment)


quarkusio#21677


$upstream:21677$

@snowdrop-bot snowdrop-bot added the upstream/closed The issue has been closed in the upstream repository label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7 - Community development upstream/closed The issue has been closed in the upstream repository
Projects
None yet
Development

No branches or pull requests

2 participants