Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add prompts default value #112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/add prompts default value #112

wants to merge 3 commits into from

Conversation

NinaDen
Copy link
Contributor

@NinaDen NinaDen commented Oct 9, 2021 •
edited
Loading

Describe what changes this pull request brings

  1. This pull request adds prompts defaults values to create template page
  2. This default values are used in extension
  3. The default values are added to animation

Describe any additional changes
N/A

Steps to test

  1. Open create template page
  2. Create template with prompts default values
  3. Confirm that the default values appear when create the template in the extension
  4. Confirm that the default values appear in animation

Screenshots

Animation with default values:
screencast 2021-10-09 15-55-12

Checklist

  • I've checked for typos
  • I've made sure overall structure consistency is preserved
  • I've made sure overall headings hierarchy is preserved
  • I've reread proposed changes twice

TODO

References
Issue Add default values to prompts #108

@NinaDen NinaDen requested review from lnikell and bolotskydev October 9, 2021 11:13
lxkuz
lxkuz reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@lxkuz lxkuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @NinaDen!

templates/frontend/src/components/shared/template-form/prompts/prompts-read-only.jsx
{prompts.map((item, index) => (
<Prompt key={index} item={item} index={index} />
))}
</ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the point of this huge change... indent change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxkuz lxkuz lxkuz left review comments

@lnikell lnikell Awaiting requested review from lnikell

@bolotskydev bolotskydev Awaiting requested review from bolotskydev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NinaDen @lxkuz