-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of #15235 - accessory checkout to locations and assets #15913
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: snipe <[email protected]>
PR Summary
|
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
The #15185 did not allow admins to see the accessories checked out to locations or assets on the location or asset pages themselves, which would make for a very confusing user experience. Unfortunately, this PR is big since there was a lot still left to do in that original (#15185) PR 😩
This introduces a more compact tabbed view on some screens, using icons and tooltips in order to prevent the icon tabs from wrapping and overwhelming the screen:
This is a rewrite of #15235, which probably also replaces/subsumes:
and partially covers:
New API Endpoints to add:
GET
-/api/v1/locations/{:id}/assigned/accessories
GET
-/api/v1/locations/{:id}/assigned/assets
GET
-/api/v1/assets/{:id}/assigned/accessories
GET
-/api/v1/assets/{:id}/assigned/assets
?Remaining To-Dos:
created_by
isn't being saved in the checkout anymore