Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset acceptence and Mails are missing translations #8233

Closed
dampfklon opened this issue Jul 16, 2020 · 3 comments
Closed

Asset acceptence and Mails are missing translations #8233

dampfklon opened this issue Jul 16, 2020 · 3 comments

Comments

@dampfklon
Copy link
Contributor

Describe the bug
Some Mails are missing translations, the asset acceptance page is missing translation.

To Reproduce
Steps to reproduce the behavior:
For example

  1. Check Out Asset
  2. Click on Link
  3. Check in Asset

Expected behavior
Every step in the process is translatable
@dampfklon
Copy link
Contributor Author

#8234 #8235 #8236 #8237
I fixed the problems in those PRs. If it is better to only have one i can also do so.

It would be helpful to also Backport those changes into on of the next releases as we need the functionality. If I should prepare another PR please say so.

@weekly-digest weekly-digest bot mentioned this issue Jul 19, 2020
Closed
@dampfklon
Copy link
Contributor Author

@snipe Had you already time to look for the PRs? Is there anything that needs to be changed?

@dampfklon
Copy link
Contributor Author

@snipe Sorry if i bother you, but have you looked into the prs by any chance?

@dampfklon dampfklon mentioned this issue Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dampfklon