Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail templates contain non translated words #7185

Closed
1 task done
ichabot opened this issue Jun 20, 2019 · 4 comments
Closed
1 task done

Mail templates contain non translated words #7185

ichabot opened this issue Jun 20, 2019 · 4 comments
Labels

Comments

@ichabot
Copy link

ichabot commented Jun 20, 2019

Please confirm you have done the following before posting your bug report:

Describe the bug
A clear and concise description of what the bug is.
All mail-templates seem to have a "Thanks," no translation works on this template text.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any asset and deploy it to a user. Mail Notification must be enabled.
  2. Click on deploy
  3. See error in the notification mail

Expected behavior
A clear and concise description of what you expected to happen.
The Text "Thanks," should be translated to the selectec language.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Server (please complete the following information):

  • Snipe-IT Version all Versions
  • OS: Ubuntu
  • Web Server: Apache
  • PHP Version 7.1.30
@ichabot
Copy link
Author

ichabot commented Jun 20, 2019

When looking for Thanks in the apachy htmldoc path I can find the following PHP files with Thanks in it. But no mail template path:

$ grep -r --include=*.php "Thanks" /var/www/snipeit/

/var/www/snipeit/vendor/phpseclib/phpseclib/phpseclib/Math/BigInteger.php:     * Thanks to Pedro Gimeno Fortea for input!
/var/www/snipeit/vendor/phpseclib/phpseclib/phpseclib/Crypt/RSA.php:     * Thanks for the heads up singpolyma!
/var/www/snipeit/vendor/symfony/console/Tests/Helper/ProgressBarTest.php:        $bar->setMessage('Thanks, bye', 'title');
/var/www/snipeit/vendor/symfony/console/Tests/Helper/ProgressBarTest.php:                " \033[44;37m Thanks, bye                           \033[0m\n".
/var/www/snipeit/resources/views/notifications/Test.blade.php:Thanks,<br>
/var/www/snipeit/resources/views/notifications/markdown/checkin-asset.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/report-expected-checkins.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/checkout-license.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/checkin-license.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/checkin-accessory.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/checkout-consumable.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/asset-requested.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/checkout-accessory.blade.php:Thanks,
/var/www/snipeit/resources/views/notifications/markdown/checkout-asset.blade.php:Thanks,
/var/www/snipeit/storage/framework/views/f55f536cbcafde43c24ebcd0f057df4db1c31f2e.php:Thanks,<br>
/var/www/snipeit/storage/framework/views/3ad476f0cfefd2810c4bb3539856990937e1d3f7.php:Thanks,

@ichabot
Copy link
Author

ichabot commented Jun 20, 2019

i just noticed that the "account/accept-asset/" website is not translated too:

image

@stale
Copy link

stale bot commented Aug 19, 2019

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Aug 19, 2019
@stale
Copy link

stale bot commented Aug 26, 2019

This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant