Non-AD LDAP sync makes all users inactive

[JorisVanEijden]

Please confirm you have done the following before posting your bug report:

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug
LDAP sync always sets inactive all users, unless an Active Directory server is used.

To Reproduce

• Configure Snipe-it to connect to a non-Active Directory LDAP
• LDAP sync to import users
• Enable login (activate) one or more users
• LDAP sync again
• Users are deactivated

The "LDAP Active Flag" has no influence on this behaviour at all.

This line causes all LDAP users to always be deactivated on every LDAP sync:

snipe-it/app/Console/Commands/LdapSync.php

Line 181 in 25884a8

$item['activated'] = 0;

Commit that broke it:
966a736

See also #6158

Expected behavior
My users can still log on after an LDAP sync.

Server (please complete the following information):

• Snipe-IT Version 4.6.15
• OS: CentOS
• Web Server: Apache
• PHP Version 7.2

[snipe]

Try upgrading to latest.