Exception Error after upgrade + some time...

[mr-gosh]

Please confirm you have done the following before posting your bug report:

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug
After patching the system to php 7.2.14 on ubuntu and upgrading snipe-it itself everything worked - a few days later (I don't know what happend in the meantime) the application shows the login screen - but after entering valid credentials an error is displayed

count(): Parameter must be an array or an object that implements Countable

(1/1) ErrorException count(): > Parameter must be an array or an object that implements Countable
--

in the error log there appears an:

[2019-01-22 10:30:37] production.ERROR: ErrorException: count(): Parameter must be an array or an object that implements Countable in /var/www/snipeit/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php:936

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Login Screen'
2. Enter Credentials
3. whoooops...

Expected behavior
normally the user is logged in...

Screenshots

Server (please complete the following information):

• Snipe-IT Version 4.6.7
• OS: Ubuntu 16.04.5 LTS
• Web Server: nginx 1.10.3
• PHP Version 7.2.14

Desktop (please complete the following information):

• OS: ubuntu linux
• Browser firefox, vivaldi and chromium tested
• Version multiple

Error Messages

• WITH DEBUG TURNED ON, if you're getting an error in your browser, include that error
• If a stacktrace is provided in the error, include that too.
• Any errors that appear in your browser's error console.
• Confirm whether the error is reproducible on the demo: https://snipeitapp.com/demo.
• Include any additional information you can find in storage/logs and your webserver's logs.

Additional context

• this is an upgraded version - and it worked after the upgrade?
• version is pulled via git
• searched for the bug - but only similar mentions demand to update to a newer version - what i did when before the bug first time appeared

snipeit-log.txt
snipeit-output.txt

[mr-gosh]

can anyone give me a hint what is going wrong here?

[snipe]

That error is typically associated with changes that PHP 7.2 brought in the way count() handles nulls, but i thought we already patched all that - and it seems odd that no one else has reported this with later versions, and that your upgrade worked just fine and then stopped. Do you have any external systems interfacing with your data, either directly or via the API?

[mr-gosh]

Hey Thanks for your time - we just use the API to Mattermost - nothing else...
Should I try to reinstall snipe-it? We have the data from nearly 30 co-corkers in there - so I try to not loose this information...
Or should I downgrade to php 7.1?

[mr-gosh]

can anyone give me a hint what is going wrong here?I downgraded to php7.1 and everything works as expected.
I think there are still some problems with php7.2 in some edge cases I encountered. So i leave this bug open - and I would like to to help fixing it. Just drop a comment and I can do things on my side for helping out.

[stale]

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

[mr-gosh]

Well - it is still.relevant as i can not upgrade to php 7.2 or newer I think

[stale]

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

[stale]

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

[stale]

This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.