Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : Doc Upload #490

Closed
tkinsella opened this issue Feb 3, 2015 · 8 comments
Closed

Feature Request : Doc Upload #490

tkinsella opened this issue Feb 3, 2015 · 8 comments

Comments

@tkinsella
Copy link

Would be great to have a document upload function for license keys. The ability to upload a purchase document or the physical key card would be great!

@tkinsella tkinsella changed the title Feature Request Feature Request : Doc Upload Feb 3, 2015
@snipe
Copy link
Owner

snipe commented Feb 4, 2015

I think this is a duplicate of #81.

@tkinsella
Copy link
Author

I'm going to say yes it is. I was looking around and must of missed that one. Sorry! On the other hand, This would be great! I just started looking through the source code and if I get a solution implemented any time shortly, i'll upload. Thanks!

@snipe
Copy link
Owner

snipe commented Feb 4, 2015

It's okay, it's kind of an old one, so it was pretty far down the list. It's not even that hard to implement, just having a hard time finding the time.

@tkinsella
Copy link
Author

If you can point me at a few files to save time, I'd gladly help!

@snipe
Copy link
Owner

snipe commented Feb 4, 2015

Heh, it's been a while, not sure I would trust that branch anymore. Laravel makes file uploads pretty easy, so then you just need to randomize the name (so no conflicts/overwriting) and add an auth filter to the route for viewing the file so that people not logged in or without permission cannot view the file. The files should be stored outside of the web root, so that URL fuzzers can't randomly guess filenames and start collecting license keys.

@snipe
Copy link
Owner

snipe commented Feb 7, 2015

I've got this up on develop right now, if you want to give it quick run-through.

screen shot 2015-02-06 at 10 02 27 pm

Demo info if here if you want to try it on the demo site before messing with it. :)

@snipe
Copy link
Owner

snipe commented Feb 7, 2015

Oops, forgot the link with the demo info :P http://snipeitapp.com/demo/

@snipe
Copy link
Owner

snipe commented Feb 9, 2015

Completed as of release 1.2.3

@snipe snipe closed this as completed Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants