Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutting down stack isn't properly implemented #19

Open
jonbo372 opened this issue Apr 28, 2023 · 0 comments
Open

Shutting down stack isn't properly implemented #19

jonbo372 opened this issue Apr 28, 2023 · 0 comments

Comments

@jonbo372
Copy link
Contributor

you cannot shutdown the stack cleanly. Parts of the flow isn't implemented and other parts isn't properly implemented.

  1. ListeningPoint::down - all of them are returning null, when they should be returning CompletionStage. And there is in fact no code to actually shut down the listening point.
  2. NettyNetworkInterface::down - looks correct but as it turns out, there is also a CountdownLatch passed in which the calling code assumes is going to be called. Should really wait for the futures to complete. Either or, currently it isn't working. Either get rid of the latch or actually call countdown on it.
  3. NettyNetworkLayer::stop - this is where it all starts and also the one that assumes the latch will be used, which it isn't. So latch.await will hang indefinitely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant