Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration option for region is not included in HubspotFormProps #134

Closed
mcortes19 opened this issue Feb 13, 2024 · 2 comments · Fixed by #135
Closed

Configuration option for region is not included in HubspotFormProps #134

mcortes19 opened this issue Feb 13, 2024 · 2 comments · Fixed by #135
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mcortes19
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Add a component and use the Region property
  2. I get a typescript error saying: Property 'region' does not exist on type 'IntrinsicAttributes & HubspotFormProps'

Expected behavior
A clear and concise description of what you expected to happen.
@snelsi
Copy link
Owner

snelsi commented Feb 13, 2024 •
edited
Loading

We have a ticket related to improving Hubspot types here: #1

Feel free to push a PR with types declaration file update 👇
https://github.com/snelsi/next-hubspot/blob/master/src/hubspot.types.ts

@snelsi snelsi added enhancement New feature or request good first issue Good for newcomers labels Feb 13, 2024
@mcortes19 mcortes19 mentioned this issue Feb 14, 2024
Merged
@snelsi
Copy link
Owner

snelsi commented Feb 14, 2024

Published as v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add HubspotFormProps missing types mcortes19/next-hubspot
2 participants
@mcortes19 @snelsi