Skip to content

Commit

Permalink
Fix broken assertion in AbstractNessieSparkSqlExtensionTest
Browse files Browse the repository at this point in the history
The assertion was modified in projectnessie#7308 with a workaround to
avoid compilation failures.

This commit reintroduces the right assertion, which became
possible when Iceberg updated Nessie to 0.61+.
  • Loading branch information
adutra authored and snazy committed Sep 22, 2023
1 parent 70c5974 commit 119ef91
Showing 1 changed file with 2 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,13 +270,7 @@ additionalRefName, defaultBranch(), currentHash))
"ASSIGN BRANCH %s TO %s AT %s IN nessie",
additionalRefName, defaultBranch(), invalidHash))
.isInstanceOf(IllegalArgumentException.class)
// TODO enable this when Nessie lib will be >= 0.61
// .hasMessage(
// Validation.HASH_OR_RELATIVE_COMMIT_SPEC_MESSAGE
// + " - but was: "
// + invalidHash)
.hasMessageContaining(Validation.HASH_RULE)
.hasMessageContaining(" - but was: " + invalidHash);
.hasMessage(Validation.HASH_OR_RELATIVE_COMMIT_SPEC_MESSAGE + " - but was: " + invalidHash);
assertThatThrownBy(
() ->
sql(
Expand Down Expand Up @@ -324,13 +318,7 @@ additionalRefName, defaultBranch(), currentHash))
"ASSIGN TAG %s TO %s AT %s IN nessie",
additionalRefName, defaultBranch(), invalidHash))
.isInstanceOf(IllegalArgumentException.class)
// TODO enable this when Nessie lib will be >= 0.61
// .hasMessage(
// Validation.HASH_OR_RELATIVE_COMMIT_SPEC_MESSAGE
// + " - but was: "
// + invalidHash)
.hasMessageContaining(Validation.HASH_RULE)
.hasMessageContaining(" - but was: " + invalidHash);
.hasMessage(Validation.HASH_OR_RELATIVE_COMMIT_SPEC_MESSAGE + " - but was: " + invalidHash);
assertThatThrownBy(
() ->
sql(
Expand Down

0 comments on commit 119ef91

Please sign in to comment.