-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commitment): add KZG commitment #317
Comments
Here is the background of this issue: When we create prover object for zkevm circuit: https://github.com/scroll-tech/scroll-prover/blob/main/integration/tests/inner_tests.rs#L18 It will call this function: https://github.com/scroll-tech/zkevm-circuits/blob/develop/prover/src/common/prover.rs#L34 As we can see that the parameter object is a binary file encoding information of As for Sirius, we will do something similar that create a Sirius prover from these parameters. |
pub fn default_value();
pub fn len() -> usize;
pub fn setup(...) -> Self;
pub fn commit(...) -> Result<C, Error> |
After I looked into detail, the kzg commitment is used in snark-verifier. As for folding, we can still use pederson commitment. While we can add kzg commitment feature, it is not urgent right now. @cyphersnake |
Currently, we are using pedersen commitment scheme. To fold circuit that based on kzg commitment like zkEVM circuit, we need also support. the kzg commitment
The text was updated successfully, but these errors were encountered: