Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back the L1 <-> L2 tests #625

Closed
pscott opened this issue Jul 3, 2024 · 1 comment · Fixed by #627
Closed

add back the L1 <-> L2 tests #625

pscott opened this issue Jul 3, 2024 · 1 comment · Fixed by #627
Assignees
@pscott
Labels
cairo1

Comments

@pscott
Copy link
Contributor

pscott commented Jul 3, 2024 •
edited
Loading

We're removed those tests in #620

Would be nice to add them back, or rework them

The idea here being:

  • Setup a config (could be dockerized tbh) that runs Anvil as the L1 devnet and starknet-devnet as the L2 devnet
  • Update the already-existing .js tests to use SpaceShard's starknet-devnet-js wrapper
  • Add back the tests in the CI
@pscott pscott self-assigned this Jul 3, 2024
@pscott
Copy link
Contributor Author

pscott commented Jul 3, 2024 •
edited
Loading

Not blocked, just need to integrate. Thanks to @ivpavici : #620 (comment)

@pscott pscott added the cairo1 label Aug 12, 2024
@pscott pscott mentioned this issue Aug 12, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pscott pscott

Labels
cairo1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add back L1 <-> L2 tests snapshot-labs/sx-starknet
1 participant
@pscott