Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop fontconfig from loading from host’s /etc/fonts/conf.d #13

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Stop fontconfig from loading from host’s /etc/fonts/conf.d #13

merged 2 commits into from
Jul 5, 2023

Conversation

gunnarhj
Copy link
Contributor

@gunnarhj gunnarhj commented Jul 4, 2023

Fixes: https://launchpad.net/bugs/2025651

At the moment the snaps in at least lunar and mantic load font configuration both from gnome-42-2204 and from the host system’s /etc/fonts/conf.d. This has proved to confuse fontconfig and result in unexpected issues. Stopping the snaps from loading from /etc/fonts/conf.d seems to fix the issue.

This PR reverts part of canonical/snapcraft@407dc755, which is sad IMO. But it’s a result of the reluctance to use font configuration from the host system as expressed in this comment, and for now the proposed change is the easiest way to stop fontconfig from being confused.

Copy link
Collaborator

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, as mentioned on canonical/snapcraft#4257 that's probably the right thing to do.

One extra note, I wonder if we should add a comment explaining that etc isn't not included and why, perhaps simply pointed to https://bugs.launchpad.net/bugs/2025651 ?

The rational would be to have things less confusing for the next person trying to figure out how things are working (which could be well be us in the future trying to remember why things are set up the way they are)

@gunnarhj
Copy link
Contributor Author

gunnarhj commented Jul 4, 2023

I wonder if we should add a comment explaining that etc isn't not included and why, perhaps simply pointed to https://bugs.launchpad.net/bugs/2025651 ?

Good idea. I added such a comment.

@kenvandine kenvandine merged commit 774d92d into canonical:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants