Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math.random() to create tokens #41

Open
k0nfig opened this issue Mar 31, 2021 · 0 comments
Open

Math.random() to create tokens #41

k0nfig opened this issue Mar 31, 2021 · 0 comments

Comments

@k0nfig
Copy link

k0nfig commented Mar 31, 2021

I was looking at the source code and noticed the use of Math.random to create tokens, I couldn't help but think that this could be a potential security issue, please correct me if I'm wrong.
Also, would you consider accepting a pull request where the token creation is refactored to use uid-safe?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@k0nfig