Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify case of filename from directory usage #118

Closed
loliver opened this issue Jun 12, 2018 · 5 comments
Closed

Add option to specify case of filename from directory usage #118

loliver opened this issue Jun 12, 2018 · 5 comments

Comments

@loliver
Copy link

loliver commented Jun 12, 2018

Hi there, fantastic library.

Is there any chance of enabling an option for -d to specify the type of case used for the filename?

Our standard in our design system is to use kebab-case rather than PascalCase.

If this is something you're interested in I'm happy to have a look at submitting a PR.

Thanks.

@gregberge
Copy link
Owner

You mean generating a file name in kebab-case instead of PascalCase? This is not possible currently. But why not!

@loliver
Copy link
Author

loliver commented Jun 14, 2018

Cool. I've was playing around with it a few days ago but had training all day yesterday, will see if I can get it working today.

@loliver
Copy link
Author

loliver commented Jun 27, 2018

So I've finally got time to work on this but am getting test failures after pulling down the repo.

Test Suites: 3 failed, 21 passed, 24 total
Tests:       7 failed, 67 passed, 74 total
Snapshots:   79 passed, 79 total

Is there any chance of a CONTRIBUTING.md or similar for those of us who want to work with the code base?

E: Looks like this is related to running on windows, even though I'm running on Linux subsystem bash it's still parsing windows style directory structures, will see whether I can fix that too.

@gregberge
Copy link
Owner

Yes contributing is missing, sorry for that. Just run lerna run build --parallel -- --watch in background when you develop, it should work fine.

@loliver
Copy link
Author

loliver commented Jul 3, 2018

Awesome, thanks. I'll hopefully have some time over the weekend to look at this, if not early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants