fix: add displayNames to generated components #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution. I would try to handle other opened PRs and release an update after easter. |
fivethreeo
pushed a commit
to fivethreeo/loadable-components
that referenced
this pull request
Nov 16, 2022
Co-authored-by: Emily Marigold Klassen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #727
Summary
Adding
displayNames to the generated loadable components makes them identifiable in react devtools.Test plan
Acceptance testing: Load one of the examples in a browser with react-devtools, make sure that the loadable wrappers dont just say "Anonymous"
Unit testing: just make sure that
displayNameis set on generated components.