Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow query-param cache busting in chunk names #229

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Allow query-param cache busting in chunk names #229

merged 2 commits into from
Feb 13, 2019

Conversation

audreyburk
Copy link
Contributor

We use query params for cache-busting (eg, chunkFilename: '[name].js?[chunkhash]'), but extname() can't properly get the extension when there's a param attached. This change would allow the use of query params.

@gregberge
Copy link
Owner

Hello @jordanburk, thanks, can you add a test please?

@audreyburk
Copy link
Contributor Author

Hi @neoziro , sorry about that! I have added tests as requested. Please let me know if they are sufficient, thank you ^_^

@gregberge
Copy link
Owner

Yes all good for me thanks!

@gregberge gregberge merged commit 71f7bcd into gregberge:master Feb 13, 2019
@audreyburk
Copy link
Contributor Author

Hi @neoziro, thank you for accepting this. Any estimate on when it will be released? Hoping to get this in use on production soon.
Thanks for your time!

@gregberge
Copy link
Owner

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants