Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude http and https from regex. Should fix #153 #155

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Exclude http and https from regex. Should fix #153 #155

merged 3 commits into from
Nov 19, 2018

Conversation

patrickhaug
Copy link
Contributor

The regex now excludes leading http (https). There was a failing test before. Should I look after that one?

@patrickhaug
Copy link
Contributor Author

Yeah, saw that too after pushing... but that failing test was something different? 😕

@gregberge
Copy link
Owner

@patrickhaug thanks, can you add a test?

To do it create a new file util.test.js :

describe('util', () => {
  describe('#joinURLPath', () => {
    it('should join paths', () => {
      expect(joinURLPath('a', 'b')).toBe('a/b')
    })
  })
})

Please add the one that was causing problem, thanks!

@gregberge gregberge merged commit 0bb2ad9 into gregberge:master Nov 19, 2018
@gregberge
Copy link
Owner

Thanks 🙏

@willdurand
Copy link

Hi, I think this still fails if the publicPath is protocol-free (e.g., //127.0.0.1:3001).

@patrickhaug
Copy link
Contributor Author

@willdurand yup, this will fail. I opened a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants