Add incognito context support #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevlened
force-pushed
the
add-incognito-context-support
branch
from
f86a823 to
dcbb08e
Compare
|
It looks very good! Awesome! |
|
Sweet ! :D Cool to know someone picked it up and completed the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
relates-to: #81 and #133
This builds on work that @Niceplace completed in #83 (thanks @Niceplace!)
Test plan
I added a test for incognito isolation. I also added the
test:incognitoscript which reruns all the existing tests withincognitoas thebrowserContext. This new test script now runs in CI.