Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify socket handling #557

Merged
merged 6 commits into from
Nov 3, 2021
Merged

Simplify socket handling #557

merged 6 commits into from
Nov 3, 2021

Commits on Nov 3, 2021

  1. socket/dhcpv4: return owned Config in Event.

    @Dirbaio
    Dirbaio committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a70c483 View commit details
    Browse the repository at this point in the history

  2. iface: own the SocketSet instead of borrowing it

    @Dirbaio
    Dirbaio committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    bde881d View commit details
    Browse the repository at this point in the history

  3. socket: remove SocketRef. 

    The intent was to run custom code after the user is done modifying the socket,
for example to update a (not yet existing) port->socket map in SocketSet. However
this wouldn't work, since the SocketRef would have to borrow the SocketSet at
the same time as the Socket to be able to notify the SocketSet.

I believe such indexing can be achieved by setting a "dirty" bit *before* giving
the socket to the user, then on poll() reindexing all dirty sockets. This could
even be faster: if user gets a socket multiple times between polls, it'd be reindexed
only once.
    @Dirbaio
    Dirbaio committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    ef213fa View commit details
    Browse the repository at this point in the history

  4. Remove braces that were previously needed to workaround SocketRef bor… 

    …row issues.
    @Dirbaio
    Dirbaio committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    9a2093e View commit details
    Browse the repository at this point in the history

  5. socket/set: remove reference counting. 

    It is never used in practice, so it's not worth the complexity
and the extra RAM usage.
    @Dirbaio
    Dirbaio committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    d242ff4 View commit details
    Browse the repository at this point in the history

  6. Fix clippys

    @Dirbaio
    Dirbaio committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    21e3dad View commit details
    Browse the repository at this point in the history