Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static files path sould stay relative #229

Closed
Osku opened this issue Dec 1, 2021 · 4 comments · Fixed by #230
Closed

Static files path sould stay relative #229

Osku opened this issue Dec 1, 2021 · 4 comments · Fixed by #230
Assignees
@Thiht
Labels
bug Something isn't working

Comments

@Osku
Copy link

Osku commented Dec 1, 2021

With the 0.17.0 release, I can not use a custom admin route /smocker/admin anymore .
Admin page does not load because static files are not found.

Now I have this index.html deployed :

<!DOCTYPE html>
<html lang="en">

<head>
    <link rel="icon" href="/assets/favicon.faca1f95.ico">
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Smocker</title>
    <base href="/smocker/admin/">
    <link rel="stylesheet" href="/assets/index.f126532d.css">
    <script>
        window.basePath = "\/smocker\/admin\/", window.version = "0.17.0";
    </script>
</head>

<body>
    <div id="root"></div>
    <script type="module" src="/assets/index.80ecc049.js"></script>
    <script src="/assets/index.a1700b8b.js" nomodule="" defer></script>
</body>

</html>

And before I had :

<!DOCTYPE html>
<html lang="en">

<head>
  <link rel="icon" href="assets/favicon.e6612986.ico" />
  <meta charset="UTF-8" />
  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
  <meta http-equiv="X-UA-Compatible" content="ie=edge" />
  <title>Smocker</title>
  <base href="/smocker/admin/" />
  <script>
    (window.basePath = "\/smocker\/admin\/"), (window.version = "0.16.3");
  </script>
  <link rel="stylesheet" href="assets/client.f3185208.css" />
</head>

<body>
  <div id="root"></div>
  <script src="assets/client.499147d7.js"></script>
</body>

</html>
@Thiht Thiht self-assigned this Dec 1, 2021
@Thiht Thiht added the bug Something isn't working label Dec 1, 2021
@Thiht
Copy link
Collaborator

Thiht commented Dec 1, 2021

Sorry, this is a regression due to the upgrade of Parcel 1 to Parcel 2 (I broke a configuration).

This will be fixed in 0.17.1

@Thiht Thiht linked a pull request Dec 1, 2021 that will close this issue
fix config-base-path #230
Merged
@Osku
Copy link
Author

Osku commented Dec 2, 2021

Merci pour la réactivité 👍

@Thiht Thiht closed this as completed in #230 Dec 2, 2021
@Osku
Copy link
Author

Osku commented Dec 17, 2021

Hello, avez-vous une date pour la release ?

@Thiht
Copy link
Collaborator

Thiht commented Dec 17, 2021

Je viens de tagger la 0.17.1, ça devrait être dispo dans une dizaine de minutes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thiht Thiht

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix config-base-path smocker-dev/smocker
2 participants
@Osku @Thiht