Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHAS/CodeQL reporting missing input sanitization #1447

Open
automartin5000 opened this issue Nov 7, 2024 · 1 comment
Open

GHAS/CodeQL reporting missing input sanitization #1447

automartin5000 opened this issue Nov 7, 2024 · 1 comment

Comments

@automartin5000
Copy link

I posted this in the AWS SDK repo, but thought I should repost here since this seems to be the source.

This code has started triggering a CodeQL finding for us.

Specifically, it's this line of code:

part = `"${part.replace(/"/g, '\\"')}"`;

The full security notification is:

Incomplete string escaping or encoding - This does not escape backslash characters in the input.

@phuhung273
Copy link

@automartin5000 +1 with you. Currently blocked because of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants